heesung-sn commented on code in PR #20058:
URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162219908


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistryImpl.java:
##########
@@ -151,7 +151,7 @@ public String getBrokerId() {
     @Override
     public CompletableFuture<List<String>> getAvailableBrokersAsync() {
         this.checkState();
-        return 
brokerLookupDataLockManager.listLocks(LOOKUP_DATA_PATH).thenApply(Lists::newArrayList);

Review Comment:
   why removing `thenApply(Lists::newArrayList);`? Can't the caller update the 
cache?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to