pgier opened a new pull request, #18440:
URL: https://github.com/apache/pulsar/pull/18440

   Add prometheus metrics which expose the per topic messages out and bytes out 
total on a per topic basis.  Currently, only the subscription level stats are 
enabled.
   
   ### Motivation
   
   There are currently two metrics `pulsar_out_bytes_total` and 
`pulsar_out_messages_total`.  The metrics represent the pulsar stats on a per 
subscription basis.  It would be convenient to be able to see the summary of 
these values per topic similar to the stats exposed by pulsar-admin.
   
   ### Modifications
   
   Added the two metrics and updated the test to verify that the output is 
correct.
   
   ### Verifying this change
   
   - [X] Make sure that the change passes the CI checks.
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.  I made an enhancement to the existing Promtheus metrics test.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local 
preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR 
description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [X] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: https://github.com/pgier/pulsar/pull/1
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to