nicoloboschi commented on code in PR #20064:
URL: https://github.com/apache/pulsar/pull/20064#discussion_r1162457796
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java:
##########
@@ -49,7 +48,7 @@ public class PulsarAdminTool {
private static int lastExitCode = Integer.MIN_VALUE;
- protected List<CustomCommandFactory> customCommandFactories = new
ArrayList();
+ protected static List<CustomCommandFactory> customCommandFactories;
Review Comment:
In pulsar shell a new instance of PulsarAdminTool (actually AdminShell) is
created when the current config changes.
I think it's fine to just cache it locally to the instance and remove
`static`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
