nodece commented on code in PR #20067:
URL: https://github.com/apache/pulsar/pull/20067#discussion_r1162985555


##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java:
##########
@@ -376,6 +395,14 @@ private synchronized void completeConnect() throws 
PulsarClientException {
 
             state = State.ProxyLookupRequests;
             lookupProxyHandler = service.newLookupProxyHandler(this);
+            if (service.getConfiguration().isAuthenticationEnabled()
+                    && 
service.getConfiguration().getAuthenticationRefreshCheckSeconds() > 0) {
+                authRefreshTask = ctx.executor().scheduleAtFixedRate(
+                        Runnables.catchingAndLoggingThrowables(() -> 
refreshAuthenticationCredentials(false)),

Review Comment:
   It will never refresh the authentication credential.
   
   `(!authState.isExpired() || !force)` always `true`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to