BewareMyPower commented on code in PR #249:
URL: https://github.com/apache/pulsar-client-cpp/pull/249#discussion_r1166661330
##########
.github/workflows/ci-pr-validation.yaml:
##########
@@ -93,6 +93,14 @@ jobs:
- name: Build
run: make -j8
+ - name: Run OAuth2 tests
+ run: |
+ docker compose -f tests/oauth2/docker-compose.yml up -d
Review Comment:
Actually I'd like to separate the 2nd standalone into another
`docker-compose.yml` like this PR. The 2nd standalone is added in
https://github.com/apache/pulsar-client-cpp/pull/126, and it took much more
time to run `pulsar-test-service-start.sh` so I pushed this PR for it:
https://github.com/apache/pulsar-client-cpp/pull/236
In future, if we need to test standalone or cluster with different configs,
setting up all these services in the same script is unnecessary. For example,
we have no tests for geo-replication now. But setting up a Pulsar instance for
multiple clusters is redundant for most of other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
