sijie commented on a change in pull request #4534: Support Avro schema for 
pulsar kafka client wrapper
URL: https://github.com/apache/pulsar/pull/4534#discussion_r293766669
 
 

 ##########
 File path: 
pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/pulsar/client/kafka/compat/KafkaProducerInterceptorWrapper.java
 ##########
 @@ -66,9 +66,9 @@
     final private org.apache.kafka.clients.producer.ProducerInterceptor<K, V> 
kafkaProducerInterceptor;
 
     // For serializer key/value, and to determine the deserializer for 
key/value.
-    private final Serializer<K> keySerializer;
+    private final PulsarKafkaSchema<K> keySerializer;
 
 Review comment:
   Why can't you use `Schema<K>`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to