cbornet commented on code in PR #20721:
URL: https://github.com/apache/pulsar/pull/20721#discussion_r1253105149
##########
pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaAbstractSource.java:
##########
@@ -274,26 +274,27 @@ public Map<String, String> getProperties(){
return properties;
}
}
- protected static class KeyValueKafkaRecord<V> extends KafkaRecord
implements KVRecord<Object, Object> {
- private final Schema<Object> keySchema;
- private final Schema<Object> valueSchema;
+ protected static class KeyValueKafkaRecord<K, W> extends KafkaRecord
implements KVRecord<K, W> {
Review Comment:
We could do
```java
protected static class KeyValueKafkaRecord<K, W> extends
KafkaRecord<KeyValue<K, W>> implements KVRecord<K, W>
```
If we could change KVRecord from
```java
public interface KVRecord<K, V> extends Record
```
to
```java
public interface KVRecord<K, V> extends Record<KeyValue<K, V>>
```
But KVRecord is marked as `@InterfaceAudience.Public`
`@InterfaceStability.Stable` so I don't think it's possible to change it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
