michaeljmarshall commented on code in PR #20268:
URL: https://github.com/apache/pulsar/pull/20268#discussion_r1270243924
##########
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java:
##########
@@ -889,9 +889,8 @@ &&
isNotBlank(authConfig.getClientAuthenticationParameters())) {
if (authConfig.isTlsAllowInsecureConnection()) {
cmd.add("--tls-allow-insecure");
}
- if (authConfig.isTlsHostnameVerificationEnable()) {
- cmd.add("--tls-enable-hostname-verification");
- }
+ cmd.add("--tls-enable-hostname-verification");
+
cmd.add(String.valueOf(authConfig.isTlsHostnameVerificationEnable()));
Review Comment:
Great point, I should update that field. Does updating that definition
change these lines of code too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
