[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20898: [fix] [ml] fix discontinuous ledger deletion

[via GitHub]

poorbarcode commented on code in PR #20898:
URL: https://github.com/apache/pulsar/pull/20898#discussion_r1280059244


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -2559,15 +2560,13 @@ private void maybeOffload(long offloadThresholdInBytes, 
long offloadThresholdInS
         }
     }
 
-    private boolean hasLedgerRetentionExpired(long ledgerTimestamp) {
-        return config.getRetentionTimeMillis() >= 0
-                && clock.millis() - ledgerTimestamp > 
config.getRetentionTimeMillis();
+    private boolean hasLedgerRetentionExpired(long retentionTimeMs, long 
ledgerTimestamp) {
+        return retentionTimeMs >= 0 && clock.millis() - ledgerTimestamp > 
retentionTimeMs;
     }
 
-    private boolean isLedgerRetentionOverSizeQuota(long sizeToDelete) {
+    private boolean isLedgerRetentionOverSizeQuota(long retentionSizeInMB, 
long sizeToDelete) {
         // Handle the -1 size limit as "infinite" size quota
-        return config.getRetentionSizeInMB() >= 0
-                && TOTAL_SIZE_UPDATER.get(this) - sizeToDelete >= 
config.getRetentionSizeInMB() * MegaByte;
+        return retentionSizeInMB >= 0 && TOTAL_SIZE_UPDATER.get(this) - 
sizeToDelete >= retentionSizeInMB * MegaByte;

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org