merlimat commented on a change in pull request #4645: Allows consumer retrieve
the sequence id that the producer set.
URL: https://github.com/apache/pulsar/pull/4645#discussion_r299260064
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -193,6 +195,7 @@ enum ProtocolVersion {
v13 = 13; // Schema-registry : added avro schema format for json
v14 = 14; // Add CommandAuthChallenge and CommandAuthResponse for
mutual auth
// Added Key_Shared subscription
+ v15 = 15; // Added sequence_id for SingleMessageMetadata, retrieve the
sequence id in batch message.
Review comment:
We don't need to add a new version here because adding the field on the
proto message will not cause any problem if the other end (broker or client) is
running an older version.
In protobuf, unknown fields are automatically ignored.
We just increase the version when adding a new feature that requires a
minimum version from the peers, so that we can check pre-emptively.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
