mattisonchao commented on code in PR #21208:
URL: https://github.com/apache/pulsar/pull/21208#discussion_r1360124880
##########
pulsar-broker/src/main/java/org/apache/pulsar/compaction/PulsarTopicCompactionService.java:
##########
@@ -106,6 +111,78 @@ public CompletableFuture<Position>
getLastCompactedPosition() {
return
CompletableFuture.completedFuture(compactedTopic.getCompactionHorizon().orElse(null));
}
+ @Override
+ public CompletableFuture<Entry> findEntryByPublishTime(long publishTime) {
+ final Predicate<Entry> predicate = entry -> {
+ try {
+ return
Commands.parseMessageMetadata(entry.getDataBuffer()).getPublishTime() >=
publishTime;
+ } finally {
+ entry.release();
+ }
+ };
+ return findFirstMatchEntry(predicate);
+ }
+
+ @Override
+ public CompletableFuture<Entry> findEntryByEntryIndex(long entryIndex) {
+ final Predicate<Entry> predicate = entry -> {
+ try {
+ BrokerEntryMetadata brokerEntryMetadata =
+
Commands.parseBrokerEntryMetadataIfExist(entry.getDataBuffer());
+ if (brokerEntryMetadata == null ||
!brokerEntryMetadata.hasIndex()) {
+ return false;
+ }
+ return brokerEntryMetadata.getIndex() >= entryIndex;
+ } finally {
+ entry.release();
+ }
+ };
+ return findFirstMatchEntry(predicate);
+ }
+
+ private CompletableFuture<Entry> findFirstMatchEntry(final
Predicate<Entry> predicate) {
+ var compactedTopicContextFuture =
compactedTopic.getCompactedTopicContextFuture();
+
+ if (compactedTopicContextFuture == null) {
+ return CompletableFuture.completedFuture(null);
+ }
+ return compactedTopicContextFuture.thenCompose(compactedTopicContext
-> {
+ LedgerHandle lh = compactedTopicContext.getLedger();
+ CompletableFuture<Long> promise = new CompletableFuture<>();
+ findFirstMatchIndexLoop(predicate, 0L, lh.getLastAddConfirmed(),
promise, null, lh);
+ return promise.thenCompose(index -> {
+ if (index == null) {
+ return CompletableFuture.completedFuture(null);
+ }
+ return readEntries(lh, index, index).thenApply(entries ->
entries.get(0));
+ });
+ });
+ }
+
+ private static void findFirstMatchIndexLoop(final Predicate<Entry>
predicate,
+ final long start, final long end,
+ final CompletableFuture<Long>
promise,
+ final Long lastMatchIndex,
+ final LedgerHandle lh) {
+ if (start > end) {
+ promise.complete(lastMatchIndex);
+ return;
+ }
+
+ long mid = (start + end) / 2;
+ CompactedTopicImpl.readEntries(lh, mid, mid).thenAccept(entries -> {
+ Entry entry = entries.get(0);
+ if (predicate.test(entry)) {
+ findFirstMatchIndexLoop(predicate, start, mid - 1, promise,
mid, lh);
Review Comment:
I have some concerns here:
1. Is it possible to get `StackOverflow` here?
2. In the case of a large amount of data, will it take up the key threads of
BK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
