lhotari commented on code in PR #21402:
URL: https://github.com/apache/pulsar/pull/21402#discussion_r1366883462
##########
pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoader.java:
##########
@@ -283,4 +304,32 @@ protected String findLibrary(final String libname) {
public String toString() {
return NarClassLoader.class.getName() + "[" +
narWorkingDirectory.getPath() + "]";
}
+
+ @Override
+ public void close() throws IOException {
+ if (this.release() == 0) {
+ CACHED_CLASS_LOADER.compute(classLoaderCacheKey, (k,
narClassLoader) -> {
Review Comment:
I think that this should be `remove`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
