mattisonchao commented on PR #21409: URL: https://github.com/apache/pulsar/pull/21409#issuecomment-1776313411
@rdhabalia >Think this way: there is no way to get specific information then should we handle this scenario or should we just not allow that user to use that software? it's not possible to auto-detect NIC in some VMs and in heterogenous h/w config you can have VMs with different NIC values where it's not possible to provide different broker-conf file to every different broker. therefore, load balancer is already handling such scenarios where nic is one of the metrics which can be skipped if it doesn't exist with a warning message. so, we can not consider the absence of NIC value as the end of the world and make broker service unavailable. Yes, I agree with this PR. I just wondered if we could improve some logic related to this area to avoid misleading load balancers. e.g. "Once NIC limit is zero, we should get rid of nic usage calculation." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
