mattisonchao commented on PR #21541: URL: https://github.com/apache/pulsar/pull/21541#issuecomment-1807572678
+1 (binding) Best, Mattison > On Nov 13, 2023, at 15:03, Qiang Zhao ***@***.***> wrote: > > > @mattisonchao commented on this pull request. > > In pip/pip-318.md <https://github.com/apache/pulsar/pull/21541#discussion_r1390683850>: > > > +In summary, I don't think we should retain null-key messages during topic compaction. > + > +# Goals > + > +# High Level Design > + > +In order to avoid introducing break changes to release version, we need to add a configuration to control whether to retain null-key messages during topic compaction. > +If the configuration is true, we will retain null-key messages during topic compaction, otherwise, we will not retain null-key messages during topic compaction. > + > +## Public-facing Changes > + > +### Configuration > + > +Add config to broker.conf > +```properties > +compactionRemainNullKey=false > Agree. > > — > Reply to this email directly, view it on GitHub <https://github.com/apache/pulsar/pull/21541#discussion_r1390683850>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR2NWCYBK5ORHVYUB35QX6LYEHA4FAVCNFSM6AAAAAA7CLQEYCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMRWGYZTOMZYGY>. > You are receiving this because you are subscribed to this thread. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
