crossoverJie commented on code in PR #21507: URL: https://github.com/apache/pulsar/pull/21507#discussion_r1395118415
########## pip/pip-316.md: ########## @@ -0,0 +1,83 @@ + +# PIP-316: Create a producerName field for DeadLetterPolicy + + +# Motivation + +Add producerName for dead letter producer, easier to locate problems. + + +# Goals + +## In Scope + +Add a new field `producerName` in `org.apache.pulsar.client.api.DeadLetterPolicy` class. + + +## Out of Scope +None. + +# High Level Design + +If `producerName` is not empty, use `producerName` as the name of the dead letter producer. Review Comment: Yeah, it work for me, which name would be better? ```java producerName: persistent://my-property/my-ns/dead-letter-topic-my-subscription-DLQ producerName: my-property/my-ns/dead-letter-topic-my-subscription-DLQ producerName: dead-letter-topic-my-subscription-DLQ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
