RobertIndie commented on code in PR #21675:
URL: https://github.com/apache/pulsar/pull/21675#discussion_r1418215427
##########
pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSourceConfig.java:
##########
@@ -152,8 +153,13 @@ public static KafkaSourceConfig load(String yamlFile)
throws IOException {
return mapper.readValue(new File(yamlFile), KafkaSourceConfig.class);
}
- public static KafkaSourceConfig load(Map<String, Object> map) throws
IOException {
+ public static KafkaSourceConfig load(Map<String, Object> map,
SourceContext sourceContext) throws IOException {
ObjectMapper mapper = new ObjectMapper();
+ try {
+ map.put("sslTruststorePassword",
sourceContext.getSecret("sslTruststorePassword"));
+ } catch (Exception e) {
+ // ignore
Review Comment:
Why we ignore this exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
