onobc commented on code in PR #21681:
URL: https://github.com/apache/pulsar/pull/21681#discussion_r1419217417
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java:
##########
@@ -852,4 +852,25 @@ public boolean isDisconnecting() {
private static final Logger log = LoggerFactory.getLogger(Producer.class);
+ /**
+ * Increments the counter that controls the throttling of the connection
by pausing reads.
Review Comment:
**[Nit]** This sounds like it increments the counter by pausing reads but
really it just increments the counter and the counter is described as... (same
for decrement method). I think something like this may clarify it a bit, wdyt?
```
/**
* Increments the counter that controls the throttling of the connection.
* <p>
* When the counter is greater than 0, the connection is throttled by
pausing reads.
* <p>
* The caller is responsible for decrementing the counter by calling
{@link #decrementThrottleCount()} when the
* connection should no longer be throttled.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
