nodece commented on code in PR #20884:
URL: https://github.com/apache/pulsar/pull/20884#discussion_r1424835055
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -3356,13 +3367,24 @@ public void
unblockDispatchersOnUnAckMessages(List<PersistentDispatcherMultipleC
}
private static class ConfigField {
+ // field holds the pulsar dynamic configuration.
final Field field;
Review Comment:
For external dynamic configuration, when using the `field`, users need to
provide the instance to which the field belongs, I think this is complex, so
the `customValue` has been added.
The purpose of this value is to compare with the old configuration value and
notify the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
