heesung-sn opened a new pull request, #21729:
URL: https://github.com/apache/pulsar/pull/21729
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see
*[Guideline - Pulsar PR Naming
Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
-->
### Motivation
<!-- Explain here the context, and why you're making that change. What is
the problem you're trying to solve. -->
For our load data system topics such as,
non-persistent://pulsar/system/loadbalancer-broker-load-data,
this allowAutoTopicCreationType=partitioned causes other broker's producer
creation to incorrectly create a new partitioned topic (although we create the
system topics as a non-partitioned topic before). Because of this, the leader
broker cannot collect all brokers' load data as the other brokers publish the
load data in different topics(partitioned topics).
#### Producer creation incorrectly creates a new partitioned topic, although
the topic was created a non-partitioned topic before.
Producer creation first fetches the partitionMedatadata from the broker, and
when fetching this partitionMedatadata, brokers automatically create a new one
with the conditions like the below code. The problem is that the broker serving
`handlePartitionMetadataRequest` might not be the owner broker (I don't see
checkBundleOwnership in the `handlePartitionMetadataRequest` code path. Hence,
the `topicExists` condition in the below code can become `false`, if not
owner, and create a new partitioned topic (by default).
https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L3167-L3175
### Modifications
Skip to auto-create ExtensibleLoadManager internal system topics, as we
precreate them now.
### Verifying this change
- added a test case to cover this logic.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions
will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since
the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed
in
a forked repository.
The tests will be run in the forked repository until all PR review comments
have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
