nodece opened a new pull request, #21734:
URL: https://github.com/apache/pulsar/pull/21734

   ### Motivation
   
   1. When `isPreciseTopicPublishRateExceeded` or 
`resourceGroupPublishRateExceeded` is `true`, the `throttledConnections.inc()` 
is not called. 
   2. We have multiple publish limiters, I think we can uniformly check the 
publish rate by 
`org.apache.pulsar.broker.service.Topic#isTopicPublishRateExceeded`.
   
   ### Modifications
   
   - Deprecate the following methods to avoid making incorrect rate checks.
     - `org.apache.pulsar.broker.service.Topic#isPublishRateExceeded`
     - 
`org.apache.pulsar.broker.service.Topic#isResourceGroupRateLimitingEnabled`
     - 
`org.apache.pulsar.broker.service.Topic#isResourceGroupPublishRateExceeded`
     - `org.apache.pulsar.broker.service.Topic#isBrokerPublishRateExceeded`
   - Using `org.apache.pulsar.broker.service.Topic#isTopicPublishRateExceeded` 
to uniformly check the publish rate.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to