heesung-sn commented on code in PR #21729:
URL: https://github.com/apache/pulsar/pull/21729#discussion_r1427582411
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -3432,10 +3432,10 @@ private CompletableFuture<Boolean>
isAllowAutoTopicCreationAsync(final TopicName
return CompletableFuture.completedFuture(false);
}
- // ServiceUnitStateChannelImpl.TOPIC expects to be a
non-partitioned-topic now.
+ // ExtensibleLoadManagerImpl.internal topics expects to be
non-partitioned-topics now.
Review Comment:
One thing we need to think about is that checking ownership there might
cause some performance impact, as we will lookup/redirect to the owner brokers
for every producer and consumer creation for non-persistent topics(and other
topic related operations).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
