merlimat commented on code in PR #56:
URL: https://github.com/apache/pulsar-adapters/pull/56#discussion_r1437153408
##########
pulsar-storm/src/main/java/org/apache/pulsar/storm/PulsarSpout.java:
##########
@@ -454,7 +454,7 @@ public void close() throws PulsarClientException {
@Override
public void unsubscribe() throws PulsarClientException {
- consumer.unsubscribe();
Review Comment:
It might be better to split the actual fix from the version change. eg:
first the version update and then using the new API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
