315157973 commented on code in PR #21765:
URL: https://github.com/apache/pulsar/pull/21765#discussion_r1439425407
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -373,10 +373,10 @@ public BrokerService(PulsarService pulsar, EventLoopGroup
eventLoopGroup) throws
this.topicLoadRequestSemaphore = new AtomicReference<Semaphore>(
new
Semaphore(pulsar.getConfiguration().getMaxConcurrentTopicLoadRequest(), false));
if (pulsar.getConfiguration().getMaxUnackedMessagesPerBroker() > 0
- &&
pulsar.getConfiguration().getMaxUnackedMessagesPerSubscriptionOnBrokerBlocked()
> 0.0) {
+ &&
pulsar.getConfiguration().getMaxUnackedMessagesPerSubscriptionOnBrokerBlocked()
> 0) {
this.maxUnackedMessages =
pulsar.getConfiguration().getMaxUnackedMessagesPerBroker();
- this.maxUnackedMsgsPerDispatcher = (int) ((maxUnackedMessages
- *
pulsar.getConfiguration().getMaxUnackedMessagesPerSubscriptionOnBrokerBlocked())
/ 100);
+ this.maxUnackedMsgsPerDispatcher = maxUnackedMessages
+ *
pulsar.getConfiguration().getMaxUnackedMessagesPerSubscriptionOnBrokerBlocked()
/ 100;
Review Comment:
Usually when upgrading a broker, we only upgrade the binary files and do not
overwrite the configuration files. Therefore, I think it's better to just
remove "/100"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
