codelipenghui commented on a change in pull request #4731: Add deleted schema
judgment when adding schema
URL: https://github.com/apache/pulsar/pull/4731#discussion_r303521194
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java
##########
@@ -129,7 +145,12 @@
.setTimestamp(clock.millis())
.addAllProps(toPairs(schema.getProps()))
.build();
- return schemaStorage.put(schemaId, info.toByteArray(),
context);
+ try {
Review comment:
```suggestion
return
getMaxDeletedVersion(schemaId).thenCompose(deleteVersion -> {
return schemaStorage.put(schemaId,
info.toByteArray(), context, deleteVersion);
})
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
