thetumbled commented on code in PR #22020:
URL: https://github.com/apache/pulsar/pull/22020#discussion_r1477645394
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/timeout/TransactionTimeoutTrackerImpl.java:
##########
@@ -57,10 +56,9 @@ public class TransactionTimeoutTrackerImpl implements
TransactionTimeoutTracker,
}
@Override
- public CompletableFuture<Boolean> addTransaction(long sequenceId, long
timeout) {
+ public void addTransaction(long sequenceId, long timeout) {
if (timeout < tickTimeMillis) {
this.transactionMetadataStoreService.endTransactionForTimeout(new
TxnID(tcId, sequenceId));
- return CompletableFuture.completedFuture(false);
Review Comment:
thanks for catch, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
