lhotari commented on code in PR #22010: URL: https://github.com/apache/pulsar/pull/22010#discussion_r1482889278
########## pulsar-otel-integration/src/main/java/org/apache/pulsar/common/stats/OpenTelemetryAttributes.java: ########## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.common.stats; Review Comment: I think that it's better to have a unique package name specific for Pulsar Opentelemetry. Could this be `org.apache.pulsar.opentelemetry` ? Do we need to shorten to `otel` at all? ########## pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/stats/package-info.java: ########## @@ -0,0 +1,19 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.functions.worker.stats; Review Comment: Shouldn't this package be specific to Otel? Please also add a javadoc description for the package. ########## pulsar-otel-integration/pom.xml: ########## @@ -0,0 +1,131 @@ +<?xml version="1.0"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<project + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"; + xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.pulsar</groupId> + <artifactId>pulsar</artifactId> + <version>3.3.0-SNAPSHOT</version> + </parent> + + <artifactId>pulsar-otel-integration</artifactId> Review Comment: just wondering if the name could be simply `pulsar-opentelemetry` to avoid abbreviations and to reduce unnecessary part `-integration`? ########## pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/PulsarWorkerService.java: ########## @@ -188,6 +190,7 @@ public void init(WorkerConfig workerConfig, this.statsUpdater = Executors .newSingleThreadScheduledExecutor(new DefaultThreadFactory("worker-stats-updater")); this.metricsGenerator = new MetricsGenerator(this.statsUpdater, workerConfig); + this.openTelemetry = new PulsarWorkerOpenTelemetry(workerConfig); Review Comment: Shouldn't this be opt-in for now? ########## pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java: ########## @@ -897,6 +902,7 @@ public void start() throws PulsarServerException { } this.metricsGenerator = new MetricsGenerator(this); + this.openTelemetry = new PulsarBrokerOpenTelemetry(config); Review Comment: Is this always enabled? Shouldn't it be opt-in for now? ########## pulsar-otel-integration/src/main/java/org/apache/pulsar/common/stats/package-info.java: ########## @@ -0,0 +1,19 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.common.stats; Review Comment: Please see previous comment about the package name. Also add a package description Javadoc here, re: https://stackoverflow.com/questions/22095487/why-is-package-info-java-useful . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
