lhotari commented on PR #22034:
URL: https://github.com/apache/pulsar/pull/22034#issuecomment-1934418030

   @liangyepianzhou It would be good to improve the description of the PR.
   
   > We need to delete the current ledger when it is rollovered.
   
   This doesn't make sense. 
   
   > Do not skip the current ledger when trimming ledgers if the state of the 
managerLedger is ClosedLedger.
   
   This makes more sense. Is this what is the actual goal? Obviously the 
trimming could result in deleting the ledger.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to