asafm commented on code in PR #22058: URL: https://github.com/apache/pulsar/pull/22058#discussion_r1511099879
########## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ########## @@ -403,15 +411,41 @@ public BrokerService(PulsarService pulsar, EventLoopGroup eventLoopGroup) throws this.defaultServerBootstrap = defaultServerBootstrap(); this.pendingLookupRequests = ObserverGauge.build("pulsar_broker_lookup_pending_requests", "-") - .supplier(() -> pulsar.getConfig().getMaxConcurrentLookupRequest() - - lookupRequestSemaphore.get().availablePermits()) + .supplier(this::getPendingLookupRequest) .register(); + this.pendingLookupRequestsCounter = pulsar.getOpenTelemetry().getMeter() + .gaugeBuilder("pulsar.broker.lookup.pending.request.usage") + .ofLongs() + .setDescription("The number of pending lookup requests in the broker. " + + "When it reaches threshold \"maxConcurrentLookupRequest\" defined in broker.conf, " + + "new requests are rejected.") + .buildWithCallback(measurement -> measurement.record(getPendingLookupRequest())); + this.pendingLookupRequestsLimit = pulsar.getOpenTelemetry().getMeter() + .gaugeBuilder("pulsar.broker.lookup.pending.request.limit") + .ofLongs() + .setDescription("The maximum number of pending lookup requests in the broker. " + + "Equal to \"maxConcurrentLookupRequest\" defined in broker.conf.") + .buildWithCallback( + measurement -> measurement.record(pulsar.getConfig().getMaxConcurrentLookupRequest())); this.pendingTopicLoadRequests = ObserverGauge.build( - "pulsar_broker_topic_load_pending_requests", "-") - .supplier(() -> pulsar.getConfig().getMaxConcurrentTopicLoadRequest() - - topicLoadRequestSemaphore.get().availablePermits()) + "pulsar_broker_topic_load_pending_requests", "-") + .supplier(this::getPendingTopicLoadRequests) .register(); + this.pendingTopicLoadRequestsCounter = pulsar.getOpenTelemetry().getMeter() + .gaugeBuilder("pulsar.broker.topic.load.pending.request.usage") Review Comment: See response at https://github.com/apache/pulsar/pull/22058#discussion_r1511099159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org