lhotari commented on PR #22174: URL: https://github.com/apache/pulsar/pull/22174#issuecomment-1979083454
I'd suggest renaming `externalListenerThreadName` to `externalListenerThreadNamePrefix`. The value is currently passed to io.netty.util.concurrent.DefaultThreadFactory under the covers where the parameter is called `poolName`. The actual thread name is in format `poolName-[poolIdCounter]-[threadIdCounter]`. This can be seen from the source code of DefaultThreadFactory: https://github.com/netty/netty/blob/85cee9d1a8881a93e7c43a02baefea75b6ade2b5/common/src/main/java/io/netty/util/concurrent/DefaultThreadFactory.java#L93-L105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
