dao-jun commented on code in PR #21772:
URL: https://github.com/apache/pulsar/pull/21772#discussion_r1515255134


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/web/RestEndpointMetricsFilter.java:
##########
@@ -87,6 +115,17 @@ public void filter(ContainerRequestContext req) throws 
IOException {
         req.setProperty(REQUEST_START_TIME, System.currentTimeMillis());
     }
 
+
+    private void recordSuccess(String path, String method, long duration) {
+        Attributes attributes = Attributes.of(PATH, path, METHOD, method);

Review Comment:
   it makes sense



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to