lhotari commented on issue #22286: URL: https://github.com/apache/pulsar/issues/22286#issuecomment-2003550178
> What do you think about https://github.com/diffplug/spotless? > > This plugin supports check and format code, I think we can use spotless instead of checkstyle. > > Once we notice that the code has been formatted by spotless on the master branch, we will be limited when doing cherry-pick operations. If we can double-check by spotless and checkstyle, this will be simpler. > > We have this discussion thread on the [[email protected]](mailto:[email protected]), but I don't know this URL, which title is `[DISCUSS] Consistent code style (esp. ws/indent) and autotools` @nodece What you are proposing is a completely different thing. I don't think that we want to change the way how code is formatted in Pulsar right now. Such changes cause unnecessary code changes without valuable benefits. We should simply upgrade checkstyle to a supported version right now. That requires migrating the configuration file slightly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
