Technoboy- commented on PR #22295: URL: https://github.com/apache/pulsar/pull/22295#issuecomment-2006832561
> > Do we need to update the default value here? > > https://github.com/apache/pulsar/blob/0c9d86016983b9683aa3b637be38e281090f40f0/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java#L86-L87 > > There's a test that makes sure that the defaults match in broker.conf and ServiceConfiguration.java . [The question about the difference was never replied](https://github.com/apache/pulsar/pull/12258#discussion_r941735863) in the original PR by @rdhabalia, so we just have to make a guess of a good default since the original PR has 2 set of values: in standalone.conf and in ServiceConfiguration.java. > > I'll revisit the changes in this PR so that I'll make the values match what is in ServiceConfiguration.java since that's what has been in use until now. Before we get the response from @rdhabalia , we'd better not merge this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
