nodece commented on PR #22380:
URL: https://github.com/apache/pulsar/pull/22380#issuecomment-2026801987

   > I don't think that we should make this change since it's a breaking 
change. A better resolution is to document the behaviour. For replication, rate 
limiting entries rather than individual messages makes a lot of sense.
   
   I understand that there is a breaking change here, but I want to keep the 
same way with the producer rate limit, please see 
https://github.com/lhotari/pulsar/blob/d61f7585e8ee1d5e76ff1ff1eb0b3380bc7178c4/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java#L324,
 we always use the batch size.
   
   Right now, when using the batch messages, the `pulsar_replication_rate_in` 
and `pulsar_replication_rate_out` doesn't match.
   
   pulsar_replication_rate_in > pulsar_replication_rate_out


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to