asafm commented on code in PR #22381:
URL: https://github.com/apache/pulsar/pull/22381#discussion_r1545571472


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java:
##########
@@ -75,6 +76,10 @@ public class ReplicatedSubscriptionsController implements 
AutoCloseable, Topic.P
                     "Counter of currently pending snapshots")
             .register();
 
+    private static final Counter timedoutSnapshotsMetric = Counter

Review Comment:
   I don't understand how this helps you understand the severity of the issue? 
It's basically serves a signal that something bad happened. Don't you need to 
know the backlog size, or am missing something on how this snapshotting process 
works?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to