poorbarcode commented on PR #22393: URL: https://github.com/apache/pulsar/pull/22393#issuecomment-2031387589
@merlimat > Is there any condition in which this was triggered by the public APIs? Regarding issue 2, described in Motivation, it will happen if batch sending is enabled. But it will not cause an OOM because all the message payload created by the public API will be built this way: - `ByteBuffer jdkBuffer = ByteBuffer.wrap( byte[] )` - `ByteBuf nettyByteBuf = Unpooled.wrappedBuffer(jdkBuffer)` So there is no memory leak because the UnpooledByteBuf will not cause issues even if it is eventually not being released. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
