lhotari commented on code in PR #877: URL: https://github.com/apache/pulsar-site/pull/877#discussion_r1548681012
########## docs/io-cli.md: ########## @@ -49,8 +49,8 @@ pulsar-admin sources create options |Flag|Description| |----|---| -| `-a`, `--archive` | The path to the NAR archive for the source. <br /> It also supports url-path (http/https/file [file protocol assumes that file already exists on worker host]) from which worker can download the package. -| `--classname` | The source's class name if `archive` is file-url-path (file://). +| `-a`, `--archive` | The absolute path to the NAR archive for the source. <br /> It also supports url-path (http/https/file [file protocol assumes that file already exists on worker host]) from which worker can download the package. +| `--classname` | The source's class name. Mandatory if `archive` doesn't reference a NAR file. Review Comment: Done. ########## docs/io-cli.md: ########## @@ -245,9 +245,9 @@ pulsar-admin sources localrun options |Flag|Description| |----|---| -| `-a`, `--archive` | The path to the NAR archive for the Source. <br /> It also supports url-path (http/https/file [file protocol assumes that file already exists on worker host]) from which worker can download the package. +| `-a`, `--archive` | The absolute path to the NAR archive for the Source. <br /> It also supports url-path (http/https/file [file protocol assumes that file already exists on worker host]) from which worker can download the package. | `--broker-service-url` | The URL for the Pulsar broker. -|`--classname`|The source's class name if `archive` is file-url-path (file://). +|`--classname`|The source's class name. Mandatory if `archive` doesn't reference a NAR file. Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
