heesung-sn commented on code in PR #22487:
URL: https://github.com/apache/pulsar/pull/22487#discussion_r1562705484
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java:
##########
@@ -544,22 +550,19 @@ private CompletableFuture<Optional<BrokerLookupData>>
getBrokerLookupData(
String bundle) {
return owner.thenCompose(broker -> {
if (broker.isEmpty()) {
- String errorMsg = String.format(
- "Failed to get or assign the owner for bundle:%s",
bundle);
- log.error(errorMsg);
- throw new IllegalStateException(errorMsg);
- }
- return CompletableFuture.completedFuture(broker.get());
- }).thenCompose(broker ->
this.getBrokerRegistry().lookupAsync(broker).thenCompose(brokerLookupData -> {
- if (brokerLookupData.isEmpty()) {
- String errorMsg = String.format(
- "Failed to lookup broker:%s for bundle:%s, the broker
has not been registered.",
- broker, bundle);
- log.error(errorMsg);
- throw new IllegalStateException(errorMsg);
+ return CompletableFuture.completedFuture(Optional.empty());
Review Comment:
nit: Shouldn't we return the IllegalStateException?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
