lhotari commented on code in PR #22221: URL: https://github.com/apache/pulsar/pull/22221#discussion_r1565191680
########## pulsar-common/src/main/java/org/apache/pulsar/common/mutable/AtomicMutableBoolean.java: ########## Review Comment: Oh yes, there's another discussion about the same matter: https://github.com/apache/pulsar/pull/22221/files/d881f5416b1b5ce2863238d74ace38889bb2f134#r1531505030 . Using Optional instead of `null`. Yes that works too. However in the Pulsar code style of minimizing allocations, we usually omit the usage of Optional and use `null`s as empty values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
