nodece commented on code in PR #22504:
URL: https://github.com/apache/pulsar/pull/22504#discussion_r1567121175
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java:
##########
@@ -111,7 +111,8 @@ public void readEntriesFailed(ManagedLedgerException
exception, Object ctx) {
callback.readEntriesComplete(entries, ctx);
recycle();
});
- } else if (cursor.config.isAutoSkipNonRecoverableData() && exception
instanceof NonRecoverableLedgerException) {
+ } else if
(cursor.getManagedLedger().getConfig().isAutoSkipNonRecoverableData()
Review Comment:
`cursor.config` equals `getManagedLedger().getConfig()`.
When the topic is loaded,
`org.apache.pulsar.broker.service.persistent.PersistentTopic#checkPersistencePolicies`
will be called, which changes the ledger config, but the `cursor.config` will
not be changed, so we need to fix that to get the latest config.
BTW, the `cursor.conf` should be deleted, and we should always call the
`getManagedLedger().getConfig()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
