shibd commented on code in PR #22531:
URL: https://github.com/apache/pulsar/pull/22531#discussion_r1570752271


##########
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedReadHandleImplV2.java:
##########
@@ -303,7 +308,7 @@ public static ReadHandle open(ScheduledExecutorService 
executor,
                                   VersionCheck versionCheck,
                                   long ledgerId, int readBufferSize, 
LedgerOffloaderStats offloaderStats,
                                   String managedLedgerName)
-            throws IOException {
+            throws IOException, 
BKException.BKNoSuchLedgerExistsOnMetadataServerException {

Review Comment:
   In Bookkeeper, if ledger metadata isn't found on the metadata server, it 
throws BKNoSuchLedgerExistsOnMetadataServerException.
   
   Likewise, when looking up the index (metadata) for the blob (ledger), this 
method should also throw the same exception for consistent handling in 
ManagerLedger.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to