BewareMyPower commented on code in PR #1208:
URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1575606991


##########
pulsar/producer_partition.go:
##########
@@ -429,12 +453,22 @@ func (p *partitionProducer) reconnectToBroker() {
                        return
                }
 
-               if p.options.BackoffPolicy == nil {
+               var assignedBrokerURL string
+
+               if connectionClosed != nil && connectionClosed.HasURL() {
+                       delayReconnectTime = 0
+                       assignedBrokerURL = connectionClosed.assignedBrokerURL
+                       connectionClosed = nil // Only attempt once

Review Comment:
   `connectionClosed` comes from the `ConnectionClosed` method through the 
`p.connectClosedCh` channel. Assigning `nil` to this local variable seems 
meaningless.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to