dragosvictor commented on code in PR #880: URL: https://github.com/apache/pulsar-site/pull/880#discussion_r1576586529
########## docs/reference-metrics-opentelemetry.md: ########## @@ -8,6 +8,153 @@ Pulsar exposes the following OpenTelemetry metrics. ## Broker +### Topic Messaging metrics Review Comment: The implementation https://github.com/apache/pulsar/pull/22467 uses asynchronous instruments, due to performance and resource efficiency reasons (more details in that PR). This is a detail, however, so it doesn't need to be in the metrics reference documentation. Furthermore, from the users point of view, this is transparent ([ref](https://opentelemetry.io/docs/specs/semconv/general/metrics/#instrument-types)). Instrument types do not impact the way the user needs to collect or interpret these values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
