Technoboy- commented on code in PR #22600:
URL: https://github.com/apache/pulsar/pull/22600#discussion_r1580764559
##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java:
##########
@@ -2473,19 +2473,17 @@ public void testTimestampOnWorkingLedger() throws
Exception {
ml.addEntry("msg02".getBytes());
+ // reopen a new ml2
ml.close();
- // Thread.sleep(1000);
- iter = ml.getLedgersInfoAsList().iterator();
- ts = -1;
- while (iter.hasNext()) {
- LedgerInfo i = iter.next();
- if (iter.hasNext()) {
- assertTrue(ts <= i.getTimestamp(), i.toString());
- ts = i.getTimestamp();
- } else {
- assertTrue(i.getTimestamp() > 0, "well closed LedgerInfo
should set a timestamp > 0");
- }
- }
+ ManagedLedgerImpl ml2 = (ManagedLedgerImpl)
factory.open("my_test_ledger", conf);
Review Comment:
Need to close the `ml2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
