dao-jun commented on code in PR #22656:
URL: https://github.com/apache/pulsar/pull/22656#discussion_r1593290960


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java:
##########
@@ -76,8 +76,8 @@ public class TopicTransactionBuffer extends 
TopicTransactionBufferState implemen
      */
     private final LinkedMap<TxnID, PositionImpl> ongoingTxns = new 
LinkedMap<>();
 
-    // when add abort or change max read position, the count will +1. Take 
snapshot will set 0 into it.
-    private final AtomicLong changeMaxReadPositionAndAddAbortTimes = new 
AtomicLong();
+    // when change max read position, the count will +1. Take snapshot will 
reset the count.
+    private final AtomicLong changeMaxReadPositionTimes = new AtomicLong();

Review Comment:
   maybe `changeMaxReadPositionCount` is better?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to