maranmaran commented on code in PR #572:
URL: https://github.com/apache/pulsar-manager/pull/572#discussion_r1596807894


##########
src/main/java/org/apache/pulsar/manager/service/impl/PulsarAdminServiceImpl.java:
##########
@@ -71,9 +71,6 @@ public class PulsarAdminServiceImpl implements 
PulsarAdminService {
     @Autowired
     private EnvironmentsRepository environmentsRepository;
 
-    @Autowired
-    private EnvironmentCacheService environmentCacheService;

Review Comment:
   Unused ref
   
   Was causing following issue:  
https://github.com/apache/pulsar-manager/issues/567
   
   



##########
src/main/resources/application.properties:
##########
@@ -134,7 +134,7 @@ default.environment.service_url=
 default.environment.bookie_url=
 
 # default superuser configuration
-default.superuser.enable=
+default.superuser.enabled=false

Review Comment:
   matches convention



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to