lhotari commented on code in PR #22703: URL: https://github.com/apache/pulsar/pull/22703#discussion_r1598408361
########## tests/docker-images/latest-version-image/Dockerfile: ########## @@ -27,12 +27,14 @@ RUN cd /go/src/github.com/apache/pulsar/pulsar-function-go/pf && go install RUN cd /go/src/github.com/apache/pulsar/pulsar-function-go/examples && go install ./... # Reference pulsar-all to copy connectors from there -FROM apachepulsar/pulsar-all:latest as pulsar-all +ARG PULSAR_ALL_IMAGE +FROM $PULSAR_ALL_IMAGE as pulsar-all ######################################## ###### Main image build ######################################## -FROM apachepulsar/pulsar:latest +ARG PULSAR_IMAGE +FROM $PULSAR_IMAGE Review Comment: It seems that `PULSAR_ALL_IMAGE` and `PULSAR_IMAGE` aren't passed as args for building the docker image -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
