lhotari commented on PR #22723:
URL: https://github.com/apache/pulsar/pull/22723#issuecomment-2115756160

   > hey [lhotari](https://github.com/lhotari), 
[Technoboy-](https://github.com/Technoboy-), 
[codelipenghui](https://github.com/codelipenghui), 
[gaoran10](https://github.com/gaoran10), 
[congbobo184](https://github.com/congbobo184) and 
[liangyepianzhou](https://github.com/liangyepianzhou)
   > 
   > can you take a look?
   
   Great contribution! Thanks. 
   Please setup [Personal 
CI](https://pulsar.apache.org/contribute/personal-ci/) and run the build in 
your fork. You'll get feedback about fixing licenses and so on. Since this is a 
new library, the license will have to be added into the distribution, following 
the same way as others. The license file would go in 
[`distribution/licenses`](https://github.com/apache/pulsar/tree/master/distribution/licenses)
 and that would be referenced in 
[`distribution/server/src/assemble/LICENSE.bin.txt`](https://github.com/apache/pulsar/tree/master/distribution/server/src/assemble/LICENSE.bin.txt)
 (footer).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to