lhotari commented on code in PR #22722:
URL: https://github.com/apache/pulsar/pull/22722#discussion_r1603761229
##########
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedInputStreamImpl.java:
##########
@@ -135,6 +133,20 @@ private boolean refillBufferIfNeeded() throws IOException {
return true;
}
+ void fillBuffer(InputStream is, int bytesToCopy) throws IOException {
+ while (bytesToCopy > 0) {
+ int writeBytes = buffer.writeBytes(is, bytesToCopy);
+ if (writeBytes < 0) {
Review Comment:
Would it make sense to have the condition `<= 0`.
```suggestion
if (writeBytes <= 0) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
