lhotari commented on code in PR #22750:
URL: https://github.com/apache/pulsar/pull/22750#discussion_r1608010007
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -414,6 +416,41 @@ private void closeLeaderElectionService() throws Exception
{
}
}
+ private boolean isManagedLedgerNotFoundException(Throwable e) {
+ Throwable realCause = e.getCause();
+ return realCause instanceof
ManagedLedgerException.MetadataNotFoundException
+ || realCause instanceof
MetadataStoreException.NotFoundException;
+ }
+
+ private void deleteHeartbeatResource() {
+ if (this.brokerService != null) {
+ LOG.info("forcefully delete heartbeat topic when close broker");
+
+ String heartbeatTopicNameV1 =
getHeartbeatTopicName(getAdvertisedAddress(), getConfiguration(), false);
+ String heartbeatTopicNameV2 =
getHeartbeatTopicName(getAdvertisedAddress(), getConfiguration(), true);
Review Comment:
I don't think that `getAdvertisedAddress()` should be passed here. In
BrokersBase.internalRunHealthCheck, it's using `getBrokerId()` instead. Please
switch to use that here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
