nodece commented on code in PR #22744:
URL: https://github.com/apache/pulsar/pull/22744#discussion_r1611715068


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java:
##########
@@ -155,6 +156,9 @@ public CompletableFuture<Boolean> canConsumeAsync(TopicName 
topicName, String ro
     @Override
     public CompletableFuture<Boolean> canLookupAsync(TopicName topicName, 
String role,
             AuthenticationDataSource authenticationData) {
+        if (SystemTopicNames.isTransactionCoordinatorAssign(topicName)) {

Review Comment:
   You should write this code in the 
`org.apache.pulsar.broker.authentication.AuthenticationService`.
   
   That looks like an important change, could you discuss this in the mailing 
list?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to